Skip to content

Adding type hints to be mypy compliant (new branch) this replaces #111 #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdavtaker wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding type hints to be mypy compliant (new branch) this replaces #111 #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99e217f
Adding type hints to be mypy compliant
sdavtaker Dec 13, 2024
f10cb41
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 13, 2024
267536e
Adding feature declaration file for 121
sdavtaker Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/121.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Adding type hints to be mypy compliant
6 changes: 3 additions & 3 deletions giturlparse/platforms/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ class BasePlatform:
}

# None means it matches all domains
DOMAINS = None
SKIP_DOMAINS = None
DEFAULTS = {}
DOMAINS: tuple[str, ...] | None = None
SKIP_DOMAINS: tuple[str, ...] | None = None
DEFAULTS: dict[str, str] = {}

def __init__(self):
# Precompile PATTERNS
Expand Down
Loading