Skip to content

Add MVPN VRI ID range #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
marehler wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add MVPN VRI ID range #682

marehler wants to merge 4 commits into from

Conversation

@marehler
Copy link

@marehler marehler commented Nov 26, 2025 •
edited
Loading

Related Issue(s)

Fixes #666.

Related Collection Role

  • cisco.nac_dc_vxlan.validate
  • cisco.nac_dc_vxlan.dtc.create
  • cisco.nac_dc_vxlan.dtc.deploy
  • cisco.nac_dc_vxlan.dtc.remove
  • other

Related Data Model Element

  • vxlan.fabric
  • vxlan.global
  • vxlan.topology
  • vxlan.underlay
  • vxlan.overlay
  • vxlan.overlay_extensions
  • vxlan.policy
  • vxlan.multisite
  • defaults.vxlan
  • other

Proposed Changes

Add MVPN_VRI_ID_RANGE parameter to eBGP and VXLAN EVPN fabric templates.

vxlan:
  underlay:
    multicast:
      mvpn_vri_id_range:
        from: 2000
        to: 2999

Test Notes

  • Applicable if TRM enabled for IPv4 or IPv6.
  • Tested for eBGP and VXLAN EVPN fabrics.
  • Both "from" and "to" (e.g. 2000-2999), and "from" only (e.g. 2000).
  • Parameter does not have defaults.

Cisco Nexus Dashboard Version

3.2.1i

Checklist

  • Latest commit is rebased from develop with merge conflicts resolved
  • New or updates to documentation has been made accordingly
  • Assigned the proper reviewers

@marehler marehler requested a review from a team as a code owner November 26, 2025 08:59
@marehler marehler changed the title MVPN VRF ID range Add MVPN VRF ID range Nov 26, 2025
@marehler marehler changed the title Add MVPN VRF ID range Add MVPN VRI ID range Nov 26, 2025
@juburnet juburnet requested a review from mtarking November 27, 2025 00:11
@juburnet juburnet added the enhancement New feature or request label Nov 27, 2025
skaszlik
skaszlik reviewed Nov 28, 2025
View reviewed changes
.../dtc/common/templates/ndfc_fabric/dc_vxlan_fabric/replication/dc_vxlan_fabric_replication.j2 Outdated
L3VNI_IPv6_MCAST_GROUP: "{{ vxlan.underlay.multicast.ipv6.trmv6_default_group | default(defaults.vxlan.underlay.multicast.ipv6.trmv6_default_group) }}"
{% endif %}
{% endif %}
{% if (((vxlan.underlay.multicast.ipv4.trm_enable | default(defaults.vxlan.underlay.multicast.ipv4.trm_enable) | ansible.builtin.bool) and
Copy link
Collaborator

@skaszlik skaszlik Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add NDFC version check. The MVPN VRI ID requires NDFC >= 12.2.2

https://www.cisco.com/c/en/us/td/docs/dcn/ndfc/1222/articles/ndfc-data-center-vxlan-evpn/data-center-vxlan-evpn.html

Copy link
Collaborator

@skaszlik skaszlik Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add one extra if condition. The doc says "TRM enabled with IPv4 underlay while fabric allows L3VNI w/o VLAN option". So we should check if vxlan.global.ebgp.enable_mvpn_vri_id_range is set to true

Copy link
Author

@marehler marehler Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the NDFC version check. The check that vxlan.global.ebgp.enable_mvpn_vri_id_range is set to true is already there. Please see line 37 in dc_vxlan_fabric_replication.j2, and line 67 in ebgp_vxlan_fabric_evpn.j2.

@marehler marehler requested a review from skaszlik December 1, 2025 10:19
@juburnet juburnet added the ready for review PR Ready for Review label Dec 4, 2025
@juburnet juburnet requested a review from mikewiebe December 4, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtarking mtarking Awaiting requested review from mtarking

@skaszlik skaszlik Awaiting requested review from skaszlik

@mikewiebe mikewiebe Awaiting requested review from mikewiebe

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request ready for review PR Ready for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for MVPN_VRI_ID_RANGE Fabric Parameter

3 participants

@marehler @skaszlik @juburnet