-
Notifications
You must be signed in to change notification settings - Fork 21
Liebert PSI5-800RT120 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: air5551 <Air@example.org>
Signed-off-by: air5551 <Air@example.org>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…s in comment [networkupstools#57] Signed-off-by: Jim Klimov <jimklimov@gmail.com>
Signed-off-by: Jim Klimov <jimklimov@gmail.com>
…l.py too Signed-off-by: Jim Klimov <jimklimov@gmail.com>
Signed-off-by: Jim Klimov <jimklimov@gmail.com>
… DEVICE:COMMENT-BLOCK:UPSCONF; there should be no TABs in it [networkupstools#57] Signed-off-by: Jim Klimov <jimklimov@gmail.com>
… inline #COMMENT for one data point [networkupstools#57] Signed-off-by: Jim Klimov <jimklimov@gmail.com>
|
Thanks! The PR got a bit mired in our syntax expectations (and checks for those) as needed for further parsing into the web pages, but I've hopefully fixed both sides of that equation :) |
Tried to read to docs as best I could but It really needs to be changed |
|
Well, one part was that for the PRs from new contributors the GHA checks do not run (must be approved by a team member) so the automated stuff did not complain to you early enough. The other part about docs - PRs to those are welcome too. Newcomers are much better at seeing which edges are rough :) |
Sanity check list
This PR is named to help easy searches (identify the vendor, device...)
Data dump file name follows this pattern (safely using ASCII characters):
<manufacturer>__<model>__<driver-name>__<nut-version>__<report-number>.<extension>(more nuances are documented on site).
This file is placed into a sub-directory named same as the
manufacturer.Was this content prepared with
nut-ddl-dump.shscript?Information from
upscdiscovered fields is provided un-commented.Additional data about supported RW variables and/or instant commands
is provided (as comments)...
...prefixed with standardized comment mark-up as documented on site,
e.g.:
and
Mark-up for other structured comments is followed (for fields, vars,
etc. as documented on site), where applicable.
For devices supported only with special settings in their
ups.confconfiguration section (e.g.
vendoridandproductidrequired alongwith a USB
subdriver), example section content is welcome as a comment.For a newly discovered supported device, a sibling PR for the main
NUT codebase (at least
docs/driver.list.in,or possibly VID/PID and other auto-detection mapping tables in the driver
sources) is welcome.
This PR is linked to relevant issue(s) and/or PRs in the NUT project,
if applicable (new driver submissions, bug fixes/discussions, etc.).