Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 15, 2026

Comparison

x Before After
Files scanned 4482 4481
Comment - Missing directory mtdowling/jmespath.php which is actually not a file
Local Time 2m19,762s 0m1,665s
CI result 8.2: 3m25s
8.3: 3m36s
8.4: 3m16s
8.5: 3m42s
https://github.com/nextcloud/3rdparty/actions/runs/20912296381
8.2: 1m12s
8.3: 2s
8.4: 1s
8.5: 3s
  • New way only works in PHP 8.3+
  • So I added a version check to switch to the old way otherwise
  • On old PHP we at least run multiple processes now

Will prepare the same for server later

@nickvergessen nickvergessen added this to the Nextcloud 33 milestone Jan 15, 2026
@nickvergessen nickvergessen self-assigned this Jan 15, 2026
@nickvergessen nickvergessen changed the title ci(lint): Use multiple lines in lint ci(lint): Use multi file argument in lint Jan 15, 2026
@nickvergessen nickvergessen marked this pull request as draft January 15, 2026 12:49
@nickvergessen

This comment was marked as resolved.

@Altahrim

This comment was marked as resolved.

@nickvergessen

This comment was marked as resolved.

Since PHP 8.3 the linting command "php -l" can consume multiple files at once.
This drastically speeds up the time necessary for the linting from ~3 minutes
to few seconds.
By also running the linting on multiple cores, the time can be dropped to < 1s

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen changed the title ci(lint): Use multi file argument in lint ci(lint): Lint multiple files at once when possible Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants