chore(records)!: Migrate data classes to records #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change, but records are the structures intended to be used for pure data objects. Signed-off-by: Stefan Niedermann <info@niedermann.it>
Member
|
Well, I'd it is fine to do and also we can simply bump to v2.0.0 to comply with semantic versioning. It is a library after all, so it is also fine to just move forward and do such changes. The number of apps making use of the lib is still relatively small and if the breaking change is easy to adapt to, that is even better then 👍 |
AndyScherzinger
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (small and easy to adapt) breaking change, but records are the structures intended to be used for pure data objects.
Note: The
FilesAppTypeRegistryitself introduced in1.3.0was a breaking change, too.