-
Notifications
You must be signed in to change notification settings - Fork 111
fix: transfer ownership confirmation string formatting #3060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ailkiv <a.ilkiv.ye@gmail.com>
Agree! |
|
@AIlkiv could you please add the changes to disallow line breaks (and possibly tabs) in the title to the front and backend? What about existing titles in the database? should we add a migration, too? |
|
@Chartman123 If I do this on the backend when saving, will it be okay? |
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
|
@AIlkiv I've added an event handler to the title to prevent adding new lines, but I think that we should also adjust If we just sanitize the string on saving in the backend the user might wonder why the title looks different after saving the form. Instead the API could throw an error if the title contains unwanted characters. |
|
@Chartman123 Thank you, I understand. I will try to finish it according to your comment. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Before:
before.mp4
After:
after.mp4