Settings icon for LDAP and encryption #3244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MorrisJobke
commented
Jan 24, 2017
MorrisJobke
commented
- follow up to add icons to navigation of personal & admin settings #3151
* follow up to #3151 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz and @nickvergessen to be potential reviewers. |
skjnldsv
approved these changes
Jan 24, 2017
ChristophWurst
added
4. to release
nickvergessen
requested changes
Jan 25, 2017
Member
There was a problem hiding this comment.
There was 1 failure:
1) OCA\User_LDAP\Tests\Settings\SectionTest::testGetIcon
Expectation failed for method name is equal to <string:imagePath> when invoked 1 time(s)
Parameter 1 for invocation OCP\IURLGenerator::imagePath('user_ldap', 'app-dark.svg') does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'app.svg'
+'app-dark.svg'
/drone/src/github.com/nextcloud/server/apps/user_ldap/lib/Settings/Section.php:80
/drone/src/github.com/nextcloud/server/apps/user_ldap/tests/Settings/SectionTest.php:74
nickvergessen
added
2. developing
nickvergessen
added
4. to release
nickvergessen
approved these changes
Jan 25, 2017
jancborchardt
previously requested changes
Jan 25, 2017
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Can you use the icon for multiple people instead of a single person? :) That makes more sense.
Member
|
Well that is the current app icon: So if we change this, we should change both. |
jancborchardt
dismissed
their stale review
Right, probably good after all since otherwise it would be confused with Contacts.
blizzz
approved these changes
Jan 25, 2017
skjnldsv
approved these changes
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.