Fix deprecated logger usage in IMAP backend to ensure compatibility with newer Nextcloud versions #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface This patch updates the `OCA\UserExternal\IMAP` class to use the modern PSR-3 LoggerInterface via dependency injection container instead of the deprecated `OC::$server->getLogger()` call. The change ensures compatibility with Nextcloud 21+ and avoids runtime exceptions like: Call to undefined method OC\Server::getLogger() The following lines were updated: - All instances of `\OC::$server->getLogger()->error(...)` are now replaced with `\OC::$server->get(\Psr\Log\LoggerInterface::class)->error(...)` This update resolves login failures due to outdated method calls and restores correct logging behavior for IMAP authentication failures. Tested successfully on Nextcloud 31.0.3. Signed-off-by: r0xd4n3t <125836836+r0xd4n3t@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the IMAP backend in the
user_externalapp to use the PSR-3LoggerInterfaceservice, replacing the deprecated\OC::$server->getLogger()method. This change resolves a fatal error when using the IMAP authentication method on recent Nextcloud versions (e.g., 31.0.x).Details
\OC::$server->getLogger()with$this->logger, which is initialized using the PSR-3 compatible service from Nextcloud's server container.loggerproperty to theIMAPclass to store the injected logger instance.This aligns the app with the current Nextcloud logging system and maintains compatibility moving forward.
Related Error
Exception: Call to undefined method OC\Server::getLogger() File: /var/www/nextcloud/apps/user_external/lib/IMAP.php Line: 125Testing