chore: only print progress on main proc #975
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rework halo logic to use Eigen Maps - add support for CGVector - keep support for DGVector/ModelArrays WIP: Still needs tidying up ... but it works!
TomMelt
commented
Jan 5, 2026
| #ifdef USE_MPI | ||
| auto& modelMPI = ModelMPI::getInstance(); | ||
| if (modelMPI.getRank() == 0) { | ||
| std::cout << tst.start << std::endl; |
Contributor
Author
There was a problem hiding this comment.
we should probably use a logger here instead. (Can we see if boost log can handle MPI? or can we make it handle MPI?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mostly stylistic change rather than functional. When you run in parallel e.g.,
mpirun -n Nthe progress is outputNtimes. This PR makes it only print on the main process (proc 0)