#step2 PR #5
Open
#step2 PR #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willing1026
reviewed
Aug 10, 2019
willing1026
left a comment
willing1026
left a comment
There was a problem hiding this comment.
저번주에 다 해놔서 몇가지만 같이 고민해보면 더 좋을거 같아ㅎㅎ
고민해봤으면 좋을거 같은 내용 몇개만 남겼어
| } | ||
|
|
||
| public static String personResult(){ | ||
| System.out.println("결과를 보고 싶은 사람은?\n"); |
There was a problem hiding this comment.
여기 앞쪽에 라인피드\n 추가하면 좋을거 같아!
실행하면 사다리 결과랑 붙어서 나오고 있어
꽝 500 100 200 결과를 보고 싶은 사람은?
|
|
||
|
|
||
| persons.settingResult(ladder, results); | ||
| String personName = InputView.personResult(); |
There was a problem hiding this comment.
all 이 아닌경우에는 반복해서 결과볼 수 있게 바꿔보면 좋을거 같아ㅎㅎ
요구사항에 반복하라는 얘기는 없어보이는데 all일때만 종료되는것 처럼 예시가 나와있어서
all일때만 종료되도록 바꿔보는것도 좋을거 같아!
결과를 보고 싶은 사람은?
pobi
실행 결과
꽝
결과를 보고 싶은 사람은?
all
| return this.persons; | ||
| } | ||
|
|
||
| public int getStartPosition(String personName) { |
| private static final String NAME_SEPARATOR = ","; | ||
|
|
||
| private List<Person> persons; | ||
| private List<Person> results; |
There was a problem hiding this comment.
이거 어떻게 할지 고민해보면 좋을거 같아ㅠㅠ
Person객체랑 똑같아질거긴 한데, 이걸 어떻게 하면 좋을거 같긴 한데...
| this.name = name; | ||
| } | ||
|
|
||
| public Person(String name, String result) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.