Skip to content

MeriamOs review fixes #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxibor merged 24 commits into from
Apr 28, 2025
Merged

MeriamOs review fixes #79

maxibor merged 24 commits into from
Apr 28, 2025

Conversation

@MeriamOs
Copy link
Collaborator

@MeriamOs MeriamOs commented Apr 3, 2025

nf-core/coproid pull request

Many thanks for contributing to nf-core/coproid!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/coproid branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

MeriamOs added 23 commits April 3, 2025 20:44
@MeriamOs
Update version + removed spelling mistake
3986fb4
@MeriamOs
Fixed review changed in genome schema
5502d1e
@MeriamOs
Fixed review changes in input schema
e2028f6
@MeriamOs
Removed some left over code from previous container issues
64be4ed
@MeriamOs
Fixed quotes and version
fcadfc2
@MeriamOs
Update nextflow_schema.json for kraken2 files
c345d46
@MeriamOs
Removed tests already covered in nextflow schema
04fdf73
@MeriamOs
Removed tests already covered in nextflow schema
3983729
@MeriamOs
Removed tests already covered in nextflow schema
2d8b9f9
@MeriamOs
Removed tests already covered in nextflow schema
db7b729
@MeriamOs
Removed bbduk patch as this module has been removed
3224e35
@MeriamOs
Updated logo
6903474
@MeriamOs
Updated logo
12080d2
@MeriamOs
Delete assets/_extensions/nf-core/coproid_logo.png
e3b65b7
@MeriamOs
Updated logo
2a3463a
@MeriamOs
Updated logo
e740008
@MeriamOs
Delete assets/_extensions/nf-core/coproid_logo1.png
2358c8d
@MeriamOs
Fixed bottleneck for bam files
a103542
@MeriamOs
Fixed quotes
f3789bf
@MeriamOs
Removed tests already covered in nextflow schema
0f6569a
@MeriamOs
Fix taxa.sqlite files
1321e1a
@MeriamOs
version harmonisation
33f3a49
@MeriamOs
version harmonisation
46353cb
@MeriamOs MeriamOs changed the title Meriam os review fixes MeriamOs review fixes Apr 3, 2025
@MeriamOs MeriamOs mentioned this pull request Apr 3, 2025
Merged
7 tasks
nvnieuwk
nvnieuwk approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxibor maxibor merged commit b21f90f into dev Apr 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MeriamOs @nvnieuwk @maxibor