Speedup anim import & various other fixes #506
Conversation
…same vertices used.
Slight fix for triangle assignment to bodypart on partition import
Import animation by default
pull out get_keys_values clean up euler import
pull out maths and type handling into dict
|
Ah damn, UV anim import is broken, still coded for old tex slots system. Needs upgrade for nodes api. All the other anim imports have been upgraded to the new faster api and tested successfully. |
HENDRIX-ZT2
changed the title
…ity to niftools collision property to fix error caused by changes in Blender 3.0 and later.
Two small fixes including niftools#499
neomonkeus
left a comment
neomonkeus
left a comment
There was a problem hiding this comment.
Not sure about moving BSInvMarker from object > scene level.
Rest look good.
io_scene_niftools/modules/nif_import/property/object/__init__.py
Outdated
Show resolved
Hide resolved
- use file name instead of generated name if possible - only extract once per run - fix too long value error for big images
just adds the node but doesn't link it
| default='NONE', | ||
| update=update_version_from_game) | ||
|
|
||
| rootnode: EnumProperty( |
There was a problem hiding this comment.
Should this be at scene level?
There was a problem hiding this comment.
Should we have a reference to an object which would used as the root node?
There was a problem hiding this comment.
Should we have a reference to an object which would used as the root node?
I think then we just delegate the problem. It's better to tag root objects (eg. those without a parent are automatically root objects)
There was a problem hiding this comment.
I was more thinking in the case that we have multiple objects tags as root object or do we allow that.
testframework/integration/modules/geometry/trishape/test_trishape.py
Outdated
Show resolved
Hide resolved
4 participants
@niftools/blender-niftools-addon-reviewer
Overview
speed up anim keyframe import, the more keys, the more speedup. about 10x on some sample nifs
Detailed Description
Fixes Known Issues
closes #180
closes #495
closes #500
closes #510
closes #517
Documentation
none
Testing
import nif / kf with animated controllers
Manual
[Set of steps to manually verify updates are working correctly]
Automated
[List of tests run, updated or added to avoid future regressions]
Additional Information
[Anything else you deem relevant]