added options to disable current display entirely #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkl-kst
requested changes
Feb 1, 2022
| {% if windDirKey %} | ||
| {{ windDirKey | translate }} | ||
| <i class="wi wi-wind from-{{data.dd}}-deg fa-fw"></i> | ||
| {% if config.showCurrentIcon or config.showCurrentTemperature or config.showCurrentText or config.showCurrentWindspeed %} |
Owner
There was a problem hiding this comment.
I think we can avoid this check because an empty div won't use any space.
Author
There was a problem hiding this comment.
I believe that would depend on whatever nefarious CSS stuff is assigned to the class "current". Personally, I prefer not to generate content that is known to be superfluous, but that's certainly not a fixed rule...
| <i class="wi wi-wind from-{{data.dd}}-deg fa-fw"></i> | ||
| {% if config.showCurrentIcon or config.showCurrentTemperature or config.showCurrentText or config.showCurrentWindspeed %} | ||
| <div class="current"> | ||
| {% if config.showCurrentIcon or config.showCurrentTemperature %} |
Owner
There was a problem hiding this comment.
Same here, I think this check isn't necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggestion for issue #54