Skip to content

Buggy #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nmanthey wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Buggy #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80e6205
cr-bot: use branch master
nmanthey Oct 11, 2020
7ce4198
cr-bot: built as much as possible
nmanthey Oct 12, 2020
12a4070
[DO NOT MERGE] test analysis a little
nmanthey Oct 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/one-line-cr-bot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ name: One Line CR Bot
on:
pull_request:
# [ACTION REQUIRED] Set the branch you want to analyze PRs for
branches: [ mainline ]
branches: [ master ]

jobs:
build:
Expand Down Expand Up @@ -52,8 +52,8 @@ jobs:
- name: one-line-cr-analysis
env:
# [ACTION REQUIRED] Adapt the values below accordingly
BASE_COMMIT: "compare/coverity-tested/smoke" # 'compare' is the name of the remote to use
BUILD_COMMAND: "make xen -B -j 2"
BASE_COMMIT: "compare/master" # 'compare' is the name of the remote to use
BUILD_COMMAND: "make xen -B -k -j 2"
CLEAN_COMMAND: "make clean -C xen -j 2"
# These settings are more preferences, and not directly related to your project
OVERRIDE_ANALYSIS_ERROR: true
Expand Down
14 changes: 13 additions & 1 deletion xen/common/grant_table.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,11 @@ active_entry_acquire(struct grant_table *t, grant_ref_t e)
*/

act = &_active_entry(t, e);

/*
How about logging?
spin_lock(&act->lock);
*/

return act;
}
Expand Down Expand Up @@ -419,7 +423,10 @@ double_gt_lock(struct grant_table *lgt, struct grant_table *rgt)
*/
if ( lgt < rgt )
{
/*
Only lock one?
grant_write_lock(lgt);
*/
grant_write_lock(rgt);
}
else
Expand Down Expand Up @@ -3163,7 +3170,8 @@ gnttab_get_status_frames(XEN_GUEST_HANDLE_PARAM(gnttab_get_status_frames_t) uop,
goto unlock;
}

for ( i = 0; i < op.nr_frames; i++ )
/* Let's check bounds */
for ( i = 0; i <= op.nr_frames; i++ )
{
gmfn = gnttab_status_gmfn(d, gt, i);
if ( copy_to_guest_offset(op.frame_list, i, &gmfn, 1) )
Expand All @@ -3188,6 +3196,7 @@ gnttab_get_version(XEN_GUEST_HANDLE_PARAM(gnttab_get_version_t) uop)
struct domain *d;
int rc;


if ( copy_from_guest(&op, uop, 1) )
return -EFAULT;

Expand Down Expand Up @@ -3773,8 +3782,11 @@ grant_table_destroy(
struct grant_table *t = d->grant_table;
int i;

/*
Test what happens if we drop a NULL check.
if ( t == NULL )
return;
*/

gnttab_destroy_arch(t);

Expand Down