Use package lock files #1392
Merged
Use package lock files #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the use of NuGet package lock files across the solution to ensure deterministic and reproducible builds by locking package versions.
Key changes:
- Added package lock files (
packages.lock.json) for all projects in the BuildingBlocks and Applications directories - Modified Dockerfiles to restore dependencies before publishing with the
--no-restoreflag - Updated GitHub Actions workflow to use
/p:ContinuousIntegrationBuild=trueflag during restore and build - Removed unnecessary
AdminCli.csprojproperties - Minor code cleanup (removed empty line)
Reviewed changes
Copilot reviewed 32 out of 134 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| BuildingBlocks/test/Crypto.Tests/packages.lock.json | Added package lock file for Crypto tests |
| BuildingBlocks/test/BuildingBlocks.Infrastructure.Tests/packages.lock.json | Added package lock file for Infrastructure tests |
| BuildingBlocks/test/BuildingBlocks.Application.Tests/packages.lock.json | Added package lock file for Application tests |
| BuildingBlocks/src/Tooling/packages.lock.json | Added package lock file for Tooling library |
| BuildingBlocks/src/DevelopmentKit.Identity/packages.lock.json | Added package lock file for Identity library |
| BuildingBlocks/src/Crypto/packages.lock.json | Added package lock file for Crypto library |
| BuildingBlocks/src/BuildingBlocks.SDK/packages.lock.json | Added package lock file for SDK library |
| BuildingBlocks/src/BuildingBlocks.Module/packages.lock.json | Added package lock file for Module library |
| BuildingBlocks/src/BuildingBlocks.Domain/packages.lock.json | Added package lock file for Domain library |
| Applications/SseServer/src/SseServer/Dockerfile | Added separate restore step for HealthCheck before publish |
| Applications/IdentityDeletionJobs/src/Job.IdentityDeletion/Workers/ActualDeletionWorker.cs | Removed extraneous blank line |
| Applications/HealthCheck/src/packages.lock.json | Added package lock file for HealthCheck application |
| Applications/ConsumerApi/src/Dockerfile | Added separate restore step for HealthCheck before publish |
| Applications/AdminCli/src/AdminCli/AdminCli.csproj | Removed redundant MSBuild properties |
| .github/workflows/test.yml | Added ContinuousIntegrationBuild flag to restore and build commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tnotheis
commented
Dec 19, 2025
erbenjak
previously approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
dotnet restore. That's why I had to add the lockfiles to the COPY statements.