-
Notifications
You must be signed in to change notification settings - Fork 1
Default presentation of credentials #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Magnus-Kuhn
wants to merge
16
commits into
release/openid4vc
Choose a base branch
from
default-presentation
base: release/openid4vc
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
db85e8e
feat: add default presentations
Magnus-Kuhn 929df57
chore: build schemas
Magnus-Kuhn 4f5cbaa
feat: allow key binding
Magnus-Kuhn e637071
test: check presentation
Magnus-Kuhn 95c9dfb
Merge branch 'release/openid4vc' into default-presentation
Magnus-Kuhn ceb8779
test: change test order
Magnus-Kuhn ebb3412
Merge branch 'release/openid4vc' into default-presentation
Magnus-Kuhn 1cd0a20
test: adapt tests after merge
Magnus-Kuhn 8a19cf6
test: set attribute id
Magnus-Kuhn 8984231
feat: validate existence of configuration
Magnus-Kuhn a4fdfe5
refactor: use case import
Magnus-Kuhn 0ad4f2c
refactor: linter
Magnus-Kuhn 3ae602e
refactor: rename property to include ...config
Magnus-Kuhn e978164
chore: build schemas
Magnus-Kuhn 2ce049d
Merge branch 'release/openid4vc' into default-presentation
mergify[bot] 13cb364
Merge branch 'release/openid4vc' into default-presentation
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need to save those settings in the attribute? Or is is possible to pass them in the UseCase? IMO the used type in the credo lib heavily blows up the generated types - and I don't really see how we set this from e.g. the app.
Additionally:
audienceandnonceshould not default to nonsense values, instead this should also be passed to this method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The end goal is that the holder shows a QR code with the presentation that is not prompted like in the OID4VP flow, which allows offline presentation and is more in line with showing a digital ticket. So the configuration has to be stored somewhere and the attribute is the simple choice.
audienceandnonceshould under normal circumstances be set by the verifier, but in this scenario that's not possible and I don't want to put the effort in to build something without them. So while it would be possible to move them to the use case, I don't see them changed to other values.If the generated types are problematic, I have no problem with simplifying them - it's easy enough to explain what is correct there without the type
@fatschi @tnotheis Do you agree with this plan?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still not understand WHO stores that information. Also, how is the verifier transfer the information to the app, when the app is just doing a button press.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no information transfer from the verifier, an example scenario is that you display a QR code with the Heidelbergpass, it is scanned at e. g. the zoo without any further prompting from the verifier. So the holder has to store the information and should get it from the issuer during the issuance, although we haven't decided yet how this happens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't those changes useless until this decision was done? Also, we could do those changes with a hardcoded config for now and then implement the config storage when we determined who stores what where ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to have a short Teams call where we discuss this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should, yeah.