Skip to content

Conversation

@Thibaulltt
Copy link
Contributor

This PR will add most Table* functions from ImGui to the python-facing imgui submodule. I've been using them on a local copy of this repo for some time now, and it's time to upstream them.

@Thibaulltt
Copy link
Contributor Author

For now, this is untested on the latest polyscope versions. @nmwsharp do you have a script somewhere on how you compile your wheels for linux? Is it only through the .github/workflow/** files? Getting stuck because GLFW does not find my X11 headers when compiling, even though it does find them when CMake runs. It might be because I'm running in a conda environment, but I did not encounter this problem when I originally patched the lib close to two years ago now...

@Thibaulltt
Copy link
Contributor Author

Nevermind, adding the include path of X11 to the CPATH environment variable allowed me to compile it and test it out. It should all work out!

@Thibaulltt
Copy link
Contributor Author

Hi @nmwsharp , I got back to my project which uses polyscope and updated the PR with Python bindings, some flags for configuration and a couple functions I forgot last time around.

Still looking forward to seeing this integrated into polyscope :)

@nmwsharp nmwsharp merged commit 2192bb3 into nmwsharp:master Dec 11, 2025
6 of 7 checks passed
@nmwsharp
Copy link
Owner

Hi, thanks so much for this PR! (and pardon for letting it languish)

I just checked it out and added a few things, but it looks great! Merged. I ran a small demo test on my end and everything seemed to be working well.

@Thibaulltt
Copy link
Contributor Author

No worries ! I am aware of the time needed to merge things upstream (or lack thereof) in small projects such as this one.

Glad to see it integrated, and ready for the next pypi release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants