Skip to content

[v25.x] v8: changing total_allocated_bytes to avoid ABI changes #60800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
caiolima wants to merge 151 commits into
base: v25.x-staging
Choose a base branch
from
Open

[v25.x] v8: changing total_allocated_bytes to avoid ABI changes #60800

caiolima wants to merge 151 commits into from

Conversation

@caiolima
Copy link
Contributor

@caiolima caiolima commented Nov 21, 2025

As noted by @targos in #60429 (comment), the implementation of total_allocated_bytes changes the ABI. This PR changes original V8 implementation to a version where there's no addition of HeapStatistics::total_allocated_bytes_ to V8's HeapStatistics, and instead we get such values using Isolate::GetTotalAllocatedBytes. This also changes code introduced by #60573 to use this new API on either v8.getHeapStatistics() and Worker::GetHeapStatistics. The goal here is to make total_allocated_bytes back portable to previous versions, but keeping the v8.getHeapStatistics() API stable once users transition from v25 to future versions. It also solves the ABI change introduced by https://github.com/nodejs/node/pull/60429/files

There's also a fix on documentation text with missing . and updating the code snippet to include total_allocated_bytes on output.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 21, 2025

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch. labels Nov 21, 2025
This was referenced Nov 21, 2025
Open
Merged
RafaelGSS
RafaelGSS approved these changes Nov 21, 2025
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 23, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70277/

@caiolima
Copy link
Contributor Author

caiolima commented Nov 25, 2025

Hi all, could someone help me trigger CI again, please?

joyeecheung and others added 18 commits November 27, 2025 10:27
@joyeecheung @targos
esm: use wasm version of cjs-module-lexer
bf27b85 
The synchronous version has been available since 1.4.0.

PR-URL: nodejs#60663
Refs: nodejs#59913
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Renegade334 @targos
doc: domain.add() does not accept timer objects
712f944 
PR-URL: nodejs#60675
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@aduh95 @targos
tools: update x64 macOS runner
d915dfa 
PR-URL: nodejs#60676
Refs: actions/runner-images#13046
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@artsiom-malakhau @targos
doc: fix incorrect slh-dsa oids in crypto.md
40f9976 
Correct wrong object identifiers listed for slh-dsa algorithms in
doc/api/crypto.md. the valid range is from id-slh-dsa-sha2-128s
(2.16.840.1.101.3.4.3.20) through id-slh-dsa-shake-256f
(2.16.840.1.101.3.4.3.31), as defined in the ietf
draft-ietf-lamps-x509-slhdsa.

Fixes: nodejs#60680
Refs: https://datatracker.ietf.org/doc/draft-ietf-lamps-x509-slhdsa/
PR-URL: nodejs#60681
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@ChALkeR @targos
test: fix test-buffer-zero-fill-cli to be effective
4eeb0d1 
PR-URL: nodejs#60623
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@KevinEady @targos
node-api: support SharedArrayBuffer in napi_create_dataview
5ed8d03 
PR-URL: nodejs#60473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@panva @targos
lib: refactor JWK import PQC support check
eb44d07 
PR-URL: nodejs#60586
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ChALkeR @targos
buffer: let Buffer.of use heap
c890668 
PR-URL: nodejs#60503
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 @targos
doc: add info about renamed flag in cli.md
8a266d1 
PR-URL: nodejs#60690
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@Renegade334 @targos
meta: add Renegade334 to collaborators
29d0318 
Fixes: nodejs#60536
PR-URL: nodejs#60714
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot @targos
deps: update cjs-module-lexer to 2.1.1
4958d58 
PR-URL: nodejs#60646
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@islandryu @targos
http,https: fix double ERR_PROXY_TUNNEL emission
438aee0 
Fixes: nodejs#60697
PR-URL: nodejs#60699
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@nodejs-github-bot @targos
test: update WPT for WebCryptoAPI to c58b6f4e0e
a05bd35 
PR-URL: nodejs#60702
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
@aduh95 @targos
test: ensure assertions are reached on more tests
eb4740d 
PR-URL: nodejs#60634
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-bot @targos
deps: update inspector_protocol to 1b1bcbbe060e8c8cd8704f00f78978c50991
15a74c0 
PR-URL: nodejs#60705
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@aduh95 @targos
doc: remove mention of SMS 2FA
5031a99 
PR-URL: nodejs#60707
Refs: nodejs/admin#1005
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@gurgunday @targos
lib: use FastBuffer for empty buffer allocation
557c9eb 
PR-URL: nodejs#60558
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@Renegade334 @targos
doc: correct tls ALPNProtocols types
3d7096e 
PR-URL: nodejs#60143
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
aduh95 and others added 19 commits December 5, 2025 14:17
@aduh95 @targos
tools: run tests --without-amaro on test-shared macOS
3fdbfb8 
PR-URL: nodejs#60902
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@Renegade334 @targos
stream: fix isErrored/isWritable for WritableStreams
56bb63c 
PR-URL: nodejs#60905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@aduh95 @targos
tools: enforce trailing commas in test/sequential
9335dc5 
PR-URL: nodejs#60892
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@aduh95 @targos
tools: enforce trailing commas in test/es-module
2fa70ea 
PR-URL: nodejs#60891
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@aduh95 @targos
tools: ignore more paths in GHA CI
41b3a3a 
PR-URL: nodejs#60920
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@legendecas @targos
util: assert getCallSites does not invoke Error.prepareStackTrace
c5a22f1 
PR-URL: nodejs#60922
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
@dependabot @targos
meta: bump peter-evans/create-pull-request from 7.0.8 to 7.0.9
5db16a2 
---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-version: 7.0.9
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#60924
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@dependabot @targos
meta: bump actions/checkout from 5.0.1 to 6.0.0
25c1abd 
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1
to 6.0.0.

- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#60925
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@dependabot @targos
meta: bump github/codeql-action from 4.31.3 to 4.31.6
e414669 
Bumps [github/codeql-action](https://github.com/github/codeql-action)
from 4.31.3 to 4.31.6.

- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.31.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#60926
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@dependabot @targos
meta: bump actions/setup-python from 6.0.0 to 6.1.0
d130e8f 
Bumps [actions/setup-python](https://github.com/actions/setup-python)
from 6.0.0 to 6.1.0.

- [Release notes](https://github.com/actions/setup-python/releases)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 6.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#60927
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@hybrist @targos
module: allow subpath imports that start with #/
99ab516 
It's a common ecosystem pattern to map a source root directory to
`@/` but it requires special tooling support. This turns `#/*` into
a more realistic alternative for that pattern.

PR-URL: nodejs#60864
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
@dependabot @targos
tools: bump mdast-util-to-hast from 13.2.0 to 13.2.1 in /tools/doc
012bac1 
Bumps [mdast-util-to-hast](https://github.com/syntax-tree/mdast-util-to-hast) from 13.2.0 to 13.2.1.
- [Release notes](https://github.com/syntax-tree/mdast-util-to-hast/releases)
- [Commits](syntax-tree/mdast-util-to-hast@13.2.0...13.2.1)

---
updated-dependencies:
- dependency-name: mdast-util-to-hast
  dependency-version: 13.2.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#60930
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mertcanaltin @targos
src: implement Windows-1252 encoding support and update related tests
abdccc0 
PR-URL: nodejs#60893
Fixes: nodejs#60888
Fixes: nodejs#59515
Fixes: nodejs#56542
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@LiviaMedeiros @targos
http2,zlib: prefer call() over apply() if argument list is not array
2dcb1d8 
PR-URL: nodejs#60834
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS @targos
test: improve config-file permission test coverage
63eb50a 
Refs: nodejs#60746 (review)
PR-URL: nodejs#60929
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mag123c @aduh95
esm: improve error messages for ambiguous module syntax
685259c 
PR-URL: nodejs#60376
Fixes: nodejs#60322
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Mohit-Raj-Saxena @aduh95
doc: add File modes cross-references in fs methods
a8fe6c3 
Adds links to the File modes section from fsPromises.open(),
fsPromises.mkdir(), and fs.mkdir() to improve discoverability
of file permission documentation.

PR-URL: nodejs#60286
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@aduh95
tools: add some options and comments to shell.nix
747fd11 
PR-URL: nodejs#60911
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@aduh95
test: skip tests not passing without NODE_OPTIONS support
eb0705a 
PR-URL: nodejs#60912
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70419/

pthier and others added 2 commits December 10, 2025 10:29
@RafaelGSS
deps: V8: cherry-pick 72b0e27bd936
9149ba4 
Original commit message:

    [regexp] Fix modifiers for ChoiceNodes

    Each alternative might modify flags when their sub-graph is emitted.
    We need to restore flags to the value at the beginning of a ChoiceNode
    for each alternative.

    Drive-by: Move regexp-modifiers test out of harmony/

    Fixed: 447583670
    Change-Id: I9f41e51f34df7659461da0a4fcd28b7e157f52e1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6995181
    Reviewed-by: Jakob Linke <jgruber@chromium.org>
    Commit-Queue: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#102838}

Refs: v8/v8@72b0e27
Refs: nodejs#60030
PR-URL: nodejs#60706
Backport-PR-URL: nodejs#60706
@Renegade334 @RafaelGSS
lib: do not provide an empty Proxy from localStorage getter
c57a40c 
PR-URL: nodejs#60776
Refs: nodejs#60303
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
@caiolima
Copy link
Contributor Author

caiolima commented Dec 17, 2025

I'm getting permission errors to look what is failing on CI. Probably it already expired. Does any of you have permission to see what's failing?

@caiolima caiolima force-pushed the backport-60573-to-v25 branch from 5669bd4 to f6b05d5 Compare January 6, 2026 13:59
@aduh95 aduh95 requested a review from a team as a code owner January 9, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.