chore: bump to new version of bb #11023
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'ACVM Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 90432b5 | Previous: 6979ab7 | Ratio |
|---|---|---|---|
perfectly_parallel_batch_inversion_opcodes |
2793105 ns/iter (± 8754) |
2261756 ns/iter (± 6237) |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 90432b5 | Previous: 6979ab7 | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
207 s |
161 s |
1.29 |
test_report_zkpassport_noir_rsa_ |
2 s |
1 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 90432b5 | Previous: 6979ab7 | Ratio |
|---|---|---|---|
rollup-block-root-single-tx |
0.003 s |
0.002 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
|
huh? I'm really confused on how this worked locally in that case. Thanks @vezenovm, dumb oversight on my part. |
Imo this shouldn't be a possible oversight. In the old BB if no Barretenberg API was specified it would be initialized in the constructor. While now that does not look to be the case. |
There is also nothing in the error that tells a user they forgot to specify a parameter when initializing the backend. It just fails when we actually use the backend. |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 90432b5 | Previous: 6979ab7 | Ratio |
|---|---|---|---|
private-kernel-inner |
2.902 s |
2.36 s |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Description
Problem
Resolves
Summary
Additional Context
User Documentation
Check one:
PR Checklist
cargo fmton default settings.