Skip to content

Conversation

@seatedscribe
Copy link

Fixes bug in selecting institution by name.

Related Issue

Searching by substring is not the correct approach since it could return incorrect bank id

Proposed Changes

  • remove in with ==

Additional Info

Test example: get_institution_id_by_name(country="IT", insitution="ING") incorrectly returns another bank

Fixes bug in selecting institution by name.
@seatedscribe
Copy link
Author

Hello, is there any issue in merging this? Please let me know

@diegotsutsumi
Copy link

I'm a user of this python client, and I couldn't see any good documentation around what should the bank_name be really, but it looks like it's intended to be a free substring to search for.

Replacing in by == would make the search much tighter potentially breaking users who are using it as a substring search. Because we can't know what the bank_name should be exactly, I am against merging this PR.

If it is indeed intended to be a search, however, this code should return multiple institutions, all matches against the institution: str parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants