-
-
Notifications
You must be signed in to change notification settings - Fork 257
feat: support wasm build #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The CI setup for notify is totally broken at the moment. But ideally, it would run for multiple toolchains, regardless of the contents of the rust-toolchain.toml file. We want to run the pipelines for the nightly toolchain as well. If you want, you can add a wasm job. I have never worked with wasi and I have no idea how notify should handle a wasi environment. How FS event notification even works there. Would it be possible to implement |
Co-authored-by: Daniel Faust <hessijames@mailbox.org>
Co-authored-by: Daniel Faust <hessijames@mailbox.org>
The wasi implemented the basic std::fs relate API, it worked fine at https://stackblitz.com/.
Yeah. The std::os::wasi::fs::MetadataExt is implement at nightly rust, the stable version hasn't it. If it move into stable version we could implement it. |
JohnTitor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we can provide a support in #676, it should make sense to fix the build on wasm in the meanwhile. Thank you for the contribution!
Co-authored-by: Daniel Faust <hessijames@mailbox.org> Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
We are using
notifyas watcher and build it to wasm32-wasip2 and run it at https://stackblitz.com/.But when using
notify-debouncer-fullto instead ofnotify, it can't build because theget_file_idis not implement at wasm. Thestd::os::wasi::fs::MetadataExtis implement at nightly rust, the stable version hasn't it. So here usingNoCachefor wasm to avoid the issue.I try to add a build wasm32-wasip2 ci, but the rust toolchain version is 1.77.2, it hasn't support the wasm32-wasip2 target.It need to bump rust toolchain at first. If you approved it, please ping me i will upgrade it at first.
Thank your excellent work!