Add upsert for credentials #83
Conversation
WalkthroughA new method, Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
lib/novu/api/subscribers.rb (1)
106-106: Fix line length violation.The comment line exceeds the maximum line length (150/120 characters) as flagged by RuboCop.
- # Upsert subscriber credentials from the Novu platform. Subscriber credentials associated to the delivery methods such as slack and push tokens. + # Upsert subscriber credentials from the Novu platform. Subscriber credentials + # associated to the delivery methods such as slack and push tokens.spec/subscribers_spec.rb (1)
163-163: Consider more accurate test description.The description "appends the subscriber credentials" might be misleading since upsert operations can both insert and update. Consider using "upserts" for clarity.
- it "appends the subscriber credentials" do + it "upserts the subscriber credentials" do
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
README.md(1 hunks)lib/novu/api/subscribers.rb(1 hunks)spec/subscribers_spec.rb(1 hunks)
🧰 Additional context used
🪛 RuboCop (1.75.5)
lib/novu/api/subscribers.rb
[convention] 106-106: Line is too long. [150/120]
(Layout/LineLength)
🪛 LanguageTool
README.md
[grammar] ~668-~668: Use proper spacing conventions.
Context: ...Upsert (append) subscriber credentials: upsert_subscriber_credentials(subscriber_id, body) ruby body = { 'providerId' => '<insert-provider-id>', 'credentials' => { # Insert all fields here } } client.upsert_subscriber_credentials('<insert-subscriber-id>', body) ` - Delete subscriber credentials by providerId: `delete_subscriber_credentials(subscriberId, providerId)` ruby client.delete_subscriber_credentials('', '') ``` - Update subscriber online status: `update...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
🔇 Additional comments (2)
lib/novu/api/subscribers.rb (1)
106-120: Good implementation of upsert functionality.The method correctly uses PATCH for upsert operations and follows the established documentation patterns. The implementation is consistent with the existing codebase.
spec/subscribers_spec.rb (1)
162-182: Well-structured test with accurate validation.The test correctly validates the PATCH request behavior and follows the established testing patterns. The implementation properly tests both the request format and expected response.
2 participants
This adds a call to the
PATCHendpoint for subscriber credentials toupsertinstead ofupdate.Summary by CodeRabbit
Documentation
New Features
Tests