-
Notifications
You must be signed in to change notification settings - Fork 1
Remove duplicate species API test #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
karilint
wants to merge
16
commits into
main
Choose a base branch
from
codex/remove-duplicate-test-files-in-src-directory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove duplicate species API test #1041
karilint
wants to merge
16
commits into
main
from
codex/remove-duplicate-test-files-in-src-directory
+463
−374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase default connection limit from default to 50 for better parallel test handling - Add acquireTimeout: 30000ms for connection acquisition - Add idleTimeout: 30000ms for idle connection management - Add minimumIdle: 0 to allow pool to scale down when not in use
Update assertion on lines 36-37 to use more idiomatic Jest matcher
Change test to properly store and assert the find result instead of testing the resultLocality existence.
- Add createTestUser function for creating test users with customizable options - Add getAuthToken function for generating JWT tokens - Add cleanupTestUser and cleanupTestUsers functions for test cleanup - Add createAuthenticatedTestUser helper for easy authenticated user creation - Add utility functions for finding and updating test users - Include bulk cleanup and Prisma disconnect utilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
src/api-teststo prevent duplicate test execution during CI.backend/src/api-testsfor a single source of truth.Description
src/api-tests/species/create.test.tsthat mirrored the canonical backend test.src/api-testspath.Testing
npm run lintand it completed successfully without new ESLint errors.npm run tscand TypeScript compilation (--noEmit) succeeded.npm run lint:cypressand it completed successfully for Cypress spec linting.Codex Task