-
Notifications
You must be signed in to change notification settings - Fork 79
Setup PlatformIO and TravisCI #65
Setup PlatformIO and TravisCI #65
Conversation
|
@nrwiersma It'd be cool to get your thoughts on this. I'm more than happy to tweak it as required :) |
|
Hi, Thanks, this seems like a nice idea and something i would interested in seeing. Couple questions. Are empty folders with just READMEs really needed? Is the Thanks, |
|
btw I have turned Travis on for this repo, so we should see it run on the next push of this PR. |
|
@baphled Were there issues with the code in the new release that need to be addressed? Or were there items on your side that fixed the issue? |
@nrwiersma We could move the extra classes out of They're really required to get a test build running though, so more than happy to remove them. |
@cgmckeever There was an issue of compiling against the ESP32 but we could resolve that later. It's easy enough to add and remove. |
|
@nrwiersma I've created a POC for keeping the If you're happy with that I'll add this PR here also, once we've got this one wrapped up. |
|
I have been buggering around with this in a branch, seeing if we can reduce the footprint. This is what I came up with: https://github.com/nrwiersma/ConfigManager/tree/travis-test. WDYT? I found some issues which i fixed at the same time. |
|
Ah, nice, that looks good to me. |
nrwiersma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution.
This PR introduces PlatformIO and TravisCI. To to help with making sure that this library compiles against various boards.
I initially had it built against 1.4, as I noticed an issues with getting 1.5 to work with one or two of my other projects.
So I figured it would be beneficial to add some automation to this project.