Fixes for scatterlist allocation, and interrupt race condition #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead, fixes memory alloc failure when host memory gets fragmented enough to not be able to allocate enough memory for a contiguous scatterlist. Don't increment ISR count if no outstanding commands, prevents test failure due to race between reaped completion, unmasking interrupts, and device canceling interrupt, sometimes spurious interrupt may occur that arrive the moment interrupts are unmasked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from contiguous raw scatterlist to use scatterlist table api instead (which allocates a page at a time for the scatterlist, then chains them together), fixes memory alloc failure when host memory gets fragmented enough to not be able to allocate enough memory for a contiguous scatterlist.
Don't increment ISR count, and mask interupts, if no outstanding commands. This prevents test failure due to race between reaped completion, unmasking interrupts, and device canceling interrupt, sometimes spurious interrupt may occur that arrive the moment interrupts are unmasked, causing the next interrupt to be masked.