Skip to content

Conversation

@JCR64
Copy link
Contributor

@JCR64 JCR64 commented Aug 2, 2025

Description of Changes


Adjusts the standard and grenade crosshair to match the PSP refactor here: nzp-team/vril-engine#100

Compared to before:

  • the crosshair spread is noticeably tighter by a few pixels
  • the crosshair origin has shifted 1 pixel down and 1 pixel to the right
  • grenade pulse doesn't look right

I'd guess originally an extra padding of 5 pixels (or one crosshair arm length) was being added, but because it wasn't documented and it isn’t present on PSP I haven't included it but a similar padding could be added back in if preferred.

For the 1 pixel shift, both crosshair positions are valid. This matches PSP exactly, but it can be shifted back if preferred.

The grenade pulse is mostly fixed by changing the cur_spread and crosshair_offset2 values back to what it is on PSP but some extra padding may be required as well.

Visual Sample


Screenshots at 640x480 resolution on Windows:

Before After
Original crosshair (debug on) Updated crosshair (debug on)
Top/Left Gap: 26px, Bottom/Right Gap: 25px Top/Left Gap: 22px, Bottom/Right Gap: 22px

Lines up with CrossHairWeapon stat here:

crosshair_spread = 22;

Checklist


  • I have thoroughly tested my changes to the best of my ability
  • I confirm I have not contributed anything that would impact Nazi Zombies: Portable's licensing and usage
  • This Pull Request fixes a critical issue that should be reviewed and merged as soon as possible

@MotoLegacy
Copy link
Member

Workflow run approved.

@JCR64
Copy link
Contributor Author

JCR64 commented Aug 9, 2025

Changed the calculations to remove any possible rounding errors. I originally tested at 640x480 but after testing some other resolutions I found it wasn't as consistent as I had hoped, but now with this change it's correct no matter what resolution is picked. It is now pretty much 1:1 with the PSP refactor.

Also addressing 2 points I made in the description:

  • the crosshair origin has shifted 1 pixel down and 1 pixel to the right

Restored this 1 pixel shift. I compared some screenshots of mainline COD games (including WaW) and this is where they have their center point (on PC at least).

  • grenade pulse doesn't look right

Changed it to the PSP values so it matches the PSP behaviour.

@JCR64 JCR64 marked this pull request as ready for review August 9, 2025 14:27
@MotoLegacy
Copy link
Member

Thanks for the updates. Does this updated logic also more accurately reflect the fired weapon's spread?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants