-
-
Notifications
You must be signed in to change notification settings - Fork 65
Add option to record Embark targets in minibuffer history #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks, this looks like a good addition - not unexpected that I would say that given that I opened the issue. Let's hope that @oantolin agrees. ;) Did you use this for a few days, and tested various completion commands/packages with it, e.g., Consult, just to see that it works as expected? |
98dd512 to
856daad
Compare
I have (with Consult and other popular packages), although any specific suggestions for what might be worth testing would be very welcome. |
856daad to
ee4a2aa
Compare
| ACTIONS@dots{})} to record for everything except the listed actions. | ||
| The default is a @samp{skip} form that excludes meta commands such as | ||
| @samp{embark-export}. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be generated from the Org file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I see.
When I attempt to export the texinfo myself (via org-texinfo-export-to-texinfo), the resulting embark.texi differs in many places from what's in the repo. Is there some other way to do this? Or should I just update README.org in the PR, and leave it to @oantolin to export to texinfo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually do it manually and just keep the relevant changes in the texinfo. But in my setup the difference is not that large.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated
Addresses oantolin#712. * embark.el (embark-record-minibuffer-history): New user option to control when acted-on minibuffer candidates are recorded in the minibuffer history. Defaults to skipping certain actions, such as export, collect, and become. (embark--record-history-p, embark--record-target-in-history): New helper functions. (embark--act): Use them to record target in history. * README.org (Advanced configuration): * embark.texi (Advanced configuration): Document the new option.
ee4a2aa to
fbdad2c
Compare
Addresses #712.
control when acted-on minibuffer candidates are recorded in the
minibuffer history. Defaults to skipping certain actions, such as
export, collect, and become.
(embark--record-history-p, embark--record-target-in-history): New
helper functions.
(embark--act): Use them to record target in history.