Skip to content

Conversation

@ultronozm
Copy link

Addresses #712.

  • embark.el (embark-record-minibuffer-history): New user option to
    control when acted-on minibuffer candidates are recorded in the
    minibuffer history. Defaults to skipping certain actions, such as
    export, collect, and become.
    (embark--record-history-p, embark--record-target-in-history): New
    helper functions.
    (embark--act): Use them to record target in history.

@minad
Copy link
Contributor

minad commented Dec 13, 2025

Thanks, this looks like a good addition - not unexpected that I would say that given that I opened the issue. Let's hope that @oantolin agrees. ;)

Did you use this for a few days, and tested various completion commands/packages with it, e.g., Consult, just to see that it works as expected?

@ultronozm ultronozm force-pushed the feat/minibuffer-history branch from 98dd512 to 856daad Compare December 13, 2025 22:06
@ultronozm
Copy link
Author

Did you use this for a few days, and tested various completion commands/packages with it, e.g., Consult, just to see that it works as expected?

I have (with Consult and other popular packages), although any specific suggestions for what might be worth testing would be very welcome.

@ultronozm ultronozm force-pushed the feat/minibuffer-history branch from 856daad to ee4a2aa Compare December 14, 2025 09:20
ACTIONS@dots{})} to record for everything except the listed actions.
The default is a @samp{skip} form that excludes meta commands such as
@samp{embark-export}.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be generated from the Org file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I see.

When I attempt to export the texinfo myself (via org-texinfo-export-to-texinfo), the resulting embark.texi differs in many places from what's in the repo. Is there some other way to do this? Or should I just update README.org in the PR, and leave it to @oantolin to export to texinfo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually do it manually and just keep the relevant changes in the texinfo. But in my setup the difference is not that large.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated

Addresses oantolin#712.

* embark.el (embark-record-minibuffer-history): New user option to
control when acted-on minibuffer candidates are recorded in the
minibuffer history.  Defaults to skipping certain actions, such as
export, collect, and become.
(embark--record-history-p, embark--record-target-in-history): New
helper functions.
(embark--act): Use them to record target in history.

* README.org (Advanced configuration):
* embark.texi (Advanced configuration): Document the new option.
@ultronozm ultronozm force-pushed the feat/minibuffer-history branch from ee4a2aa to fbdad2c Compare December 23, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants