Completion update #788
Open
Completion update #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces consult-preview-at-point-mode
Introduce embark--with-completion-list-buffer which switches to an active completions buffer if there is one tied to the current minibuffer.
The completion list candidate takes precendence if there is one. Only if no candidate has been selected, take the top minibuffer candidate.
minad
added a commit
to minad/consult
that referenced
this pull request
Dec 23, 2025
Contributor
Author
|
For testing I recommend the settings from https://github.com/minad/consult?tab=readme-ov-file#default-completion-ui-with-auto-update. These settings make the default completion UI more comfortable to use. |
Owner
|
Oh, is this something I need to test on the current master? I'm using the released Emacs 30.1. Since I have now lost most of my fear of compiling Emacs from source I guess I could test this. |
Contributor
Author
|
Yes, you need Emacs master. I had forgotten that you've just moved to Emacs 30 a while ago. :/ But if you can test on Emacs 30 it would also be good, I guess. My main concern is the reordering of the target finder. I am not sure if this has unexpected implications. |
minad
force-pushed
the
completion-update
branch
from
708c4bf to
f21dedb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #787. Please test carefully. You need
minibuffer-visible-completionsset totin order to see the effect. This settings allows you to "remote" control the Completions buffer from the minibuffer. You can navigate with up and down keys from the minibuffer.