Consolidate /create and /templates #306
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lukaw3d
reviewed
Sep 29, 2025
| const trackedEvents = useRef<Set<number>>(new Set()) | ||
|
|
||
| useEffect(() => { | ||
| if (flowMode !== 'create') return |
Member
There was a problem hiding this comment.
ah handling sideeffects here is annoying
lukaw3d
reviewed
Sep 29, 2025
Comment on lines
+88
to
+93
| {({ openConnectModal }) => { | ||
| return isConnected ? ( | ||
| <Button size="lg" asChild> | ||
| <Link to="/create"> | ||
| Get started | ||
| <ArrowRight /> |
Member
There was a problem hiding this comment.
what I meant was: when user is on path /create: if wallet is not connected, show connect button + TemplatesList. If wallet is connected then show step 0 (TemplatesList). Delete /templates path. Delete "Get started" button
lukaw3d
reviewed
Sep 29, 2025
| <div className="mx-auto px-8 py-12"> | ||
| <div className="mb-10"> | ||
| <h1 className="text-2xl font-white font-bold text-center mb-8"> | ||
| Create your app from a template |
Member
There was a problem hiding this comment.
having a different page title above TemplatesList
"Create your app from a template" vs "Start by Selecting a Template" is annoying. maybe not worth consolidating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on the discussion #267 (comment)