Skip to content

Conversation

@lubej
Copy link
Contributor

@lubej lubej commented Nov 20, 2025

This PR integrates oasisprotocol/erc-8004#5, by including rofl-8004 service inside compose.yaml. Provides another step, that can be skipped in create flow. Shows the ERC-8004 "token"/NFT in AppDetails.

Part of #359

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

Deployed to Cloudflare Pages

Latest commit: 3659698b3353651f34629ec5167f05f556d3f43a
Status:✅ Deploy successful!
Preview URL: https://ec3f1d8c.rofl-app.pages.dev
Alias: https://pr-361.rofl-app.pages.dev

@lubej
Copy link
Contributor Author

lubej commented Nov 20, 2025

Testing requirements:

  • Pinata JWT token
  • Infura API KEY
  • Sepolia testnet account with some SepoliaETH, which will pay for Agenty Identity registration

Current flow only works with existing templates, not with custom build, as custom build needs additional validation, so it does not override the ERC-8004 secrets.

@lubej lubej requested review from buberdds, csillag, lukaw3d and matevz and removed request for buberdds November 20, 2025 15:04
@tjanez
Copy link
Member

tjanez commented Nov 20, 2025

Current flow only works with existing templates, not with custom build, as custom build needs additional validation, so it does not override the ERC-8004 secrets.

@lubej, @matevz, I think that for the hackathoners the Custom App/Build template would be the one that will be used.

And @buberdds just enabled the Custom App/Build to also work with Testnet in #362.

@buberdds, can you help @lubej with enabling ERC-8004 support for Custom App/Build?

@lubej
Copy link
Contributor Author

lubej commented Nov 20, 2025

Current flow only works with existing templates, not with custom build, as custom build needs additional validation, so it does not override the ERC-8004 secrets.

@lubej, @matevz, I think that for the hackathoners the Custom App/Build template would be the one that will be used.

And @buberdds just enabled the Custom App/Build to also work with Testnet in #362.

@buberdds, can you help @lubej with enabling ERC-8004 support for Custom App/Build?

Right, so ERC-8004 support for Custom App/Build shouldn't be hard to implement, just needs some validation for secrets, and the step should be the same as in template flow. Will add this tomorrow. I just went with the template flow first, as it was easier to test.

@lubej lubej force-pushed the ml/erc-8004 branch 4 times, most recently from eaa3b6a to d095658 Compare November 21, 2025 13:53
@rube-de
Copy link

rube-de commented Nov 21, 2025

I would request the full RPC url instead of making it dependent on infura.
The validator agent address would be also helpful in the form.

@lubej
Copy link
Contributor Author

lubej commented Nov 21, 2025

I would request the full RPC url instead of making it dependent on infura. The validator agent address would be also helpful in the form.

Right, as for the RPC url and validator address, I would rather have a dropdown with available networks, and you could change them potentially via secrets if you wanted to. And if you want some custom implementation, you can do it via CLI anyway. I wouldn't want the complexity of free form on ROFL App - as the intention is for less advanced users - and they may wonder why is not working as intended. This is just for the initial implementation, I think we can fine tune it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants