-
Notifications
You must be signed in to change notification settings - Fork 1
Add initial ERC-8004 support #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Deployed to Cloudflare Pages
|
|
Testing requirements:
Current flow only works with existing templates, not with custom build, as custom build needs additional validation, so it does not override the ERC-8004 secrets. |
@lubej, @matevz, I think that for the hackathoners the Custom App/Build template would be the one that will be used. And @buberdds just enabled the Custom App/Build to also work with Testnet in #362. @buberdds, can you help @lubej with enabling ERC-8004 support for Custom App/Build? |
Right, so ERC-8004 support for Custom App/Build shouldn't be hard to implement, just needs some validation for secrets, and the step should be the same as in template flow. Will add this tomorrow. I just went with the template flow first, as it was easier to test. |
eaa3b6a to
d095658
Compare
|
I would request the full RPC url instead of making it dependent on infura. |
Right, as for the RPC url and validator address, I would rather have a dropdown with available networks, and you could change them potentially via secrets if you wanted to. And if you want some custom implementation, you can do it via CLI anyway. I wouldn't want the complexity of free form on ROFL App - as the intention is for less advanced users - and they may wonder why is not working as intended. This is just for the initial implementation, I think we can fine tune it later. |
- change prefix to ERC8004
- add validation for ERC-8004 reserved fields
- Remove custom build skip for ERC8004Step
- pin rofl-8004 image
- update signing key placeholder to reflect the validation
- enable rest of the optional configuration keys
- Make signing key optional
- Add MCP,A2A,ENS fields
This PR integrates oasisprotocol/erc-8004#5, by including rofl-8004 service inside compose.yaml. Provides another step, that can be skipped in create flow. Shows the ERC-8004 "token"/NFT in AppDetails.
Part of #359