feat: implement RLP encoding for mock receipt proofs with ethers #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors the RLP (Recursive Length Prefix) encoding implementation for mock receipt proofs by replacing custom RLP encoding logic with ethers v6's native encodeRlp function. The change simplifies the codebase by removing approximately 60 lines of manual RLP encoding code and leveraging the well-tested native implementation.
Key Changes:
- Replaced custom
encodeRlpBytes,encodeRlpList, andencodeRlpUintimplementations with ethers v6 nativeencodeRlpandgetBytesfunctions - Added comprehensive unit tests to verify RLP encoding correctness and decodability
- Updated documentation to clarify the use of ethers v6 native RLP encoding
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| contracts/test/helpers/proofHelpers.ts | Refactored to use ethers v6 native RLP encoding functions, removing ~60 lines of custom encoding logic |
| contracts/test/unit/proofHelpers.test.ts | New test suite with comprehensive coverage of RLP encoding behavior, proof structure, and data integrity |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matevz
approved these changes
Dec 12, 2025
rube-de
deleted the
rube/15-evaluate-if-for-proofhelpersts-ethersutilsrlp-may-be-better-suited
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.