Add a security note about signing apks in CI #2242
Merged
+10
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
buberdds
approved these changes
Dec 23, 2025
tjanez
approved these changes
Dec 23, 2025
.github/workflows/ci-build.yml
Outdated
| echo "${{ secrets.KEYSTORE_FILE }}" | base64 --decode > "android/release.jks" | ||
| - name: Sign AAB and APK | ||
| # Security: should not sign apks on unmerged pullrequest. Otherwise someone | ||
| # could sign a malicious app and distribute it with our valid signature (tho |
Member
There was a problem hiding this comment.
Suggested change
| # could sign a malicious app and distribute it with our valid signature (tho | |
| # could sign a malicious app and distribute it with our valid signature (though |
lukaw3d
force-pushed
the
lw/comment-signing-apks
branch
from
9b60c98 to
bee5cc1
Compare
lukaw3d
force-pushed
the
lw/comment-signing-apks
branch
from
bee5cc1 to
4f4dabf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.