-
Notifications
You must be signed in to change notification settings - Fork 19
Bump tmp and release-it #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump tmp and release-it #1030
Conversation
|
@dependabot rebase |
Removes [tmp](https://github.com/raszi/node-tmp). It's no longer used after updating ancestor dependency [release-it](https://github.com/release-it/release-it). These dependencies need to be updated together. Removes `tmp` Updates `release-it` from 17.6.0 to 19.0.4 - [Release notes](https://github.com/release-it/release-it/releases) - [Changelog](https://github.com/release-it/release-it/blob/main/CHANGELOG.md) - [Commits](release-it/release-it@17.6.0...19.0.4) --- updated-dependencies: - dependency-name: tmp dependency-version: dependency-type: indirect - dependency-name: release-it dependency-version: 19.0.4 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
e4d899e to
485eac6
Compare
|
@dependabot rebase |
alexcos20
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI automated code review (Gemini 3).
Overall risk: low
Summary:
This pull request, created by Dependabot, updates the release-it development dependency from version 17.6.0 to 19.0.4. Additionally, the tmp indirect dependency has been removed, as it's no longer required by the updated release-it package. The changes are confined to package.json and package-lock.json.
Comments:
• [INFO][other] The release-it package has undergone a major version bump from 17 to 19. While this is a development dependency, it's essential to verify that any existing release automation scripts or CI/CD configurations that rely on release-it are still compatible with the new version. Please ensure the release workflow functions as expected after this update.
• [INFO][other] The tmp dependency has been removed. This is a positive change, as it reduces the dependency tree and potential attack surface. It's good practice to eliminate unused dependencies.
• [INFO][other] Given the significant changes in package-lock.json due to the major version bump of release-it and the removal of tmp, it would be beneficial to run all standard development checks (e.g., npm install, npm test, npm run lint) to ensure no unexpected regressions have been introduced into the development environment or build process.
|
Looks like these dependencies are no longer a dependency, so this is no longer needed. |
alexcos20
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI automated code review (Gemini 3).
Overall risk: low
Summary:
This pull request, initiated by Dependabot, updates the release-it development dependency from version 17.6.0 to 19.0.4. As a result of this update, the tmp dependency is also removed, as it is no longer required by the updated release-it package. The changes are confined to package.json and package-lock.json.
Comments:
• [INFO][other] The release-it package has been updated across major versions (17.x to 19.x). While this is a development dependency, it's good practice to quickly review the changelogs between 17.6.0 and 19.0.4 to ensure no breaking changes in its API or configuration could unexpectedly affect our release process, even if our usage is basic. The Dependabot message mentions reviewing release notes and changelog, which is a good starting point.
• [INFO][other] The removal of the tmp dependency is a positive cleanup, indicating that release-it no longer relies on it. This helps reduce the overall dependency footprint. This change, alongside the release-it update, looks sound for a dependency bump.
alexcos20
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI automated code review (Gemini 3).
Overall risk: low
Summary:
This pull request, created by Dependabot, updates the release-it development dependency from version ^17.6.0 to ^19.0.4. It also removes the tmp dependency, which was an indirect dependency of release-it and is no longer needed after the update. The changes primarily affect package.json and package-lock.json.
Comments:
• [INFO][other] The release-it dependency is updated across major versions (17.x to 19.x). As this is a development dependency used for release automation, ensure that existing release scripts or CI/CD configurations are compatible with the changes introduced in release-it versions 18 and 19. It's recommended to review the official changelog for any breaking changes that might affect the release workflow.
• [INFO][other] The package-lock.json shows a substantial number of changes due to the release-it major version bump and the removal of the tmp dependency. This is expected behavior for such an update. Ensure that npm install (or equivalent) runs successfully after this change.
Removes tmp. It's no longer used after updating ancestor dependency release-it. These dependencies need to be updated together.
Removes
tmpUpdates
release-itfrom 17.6.0 to 19.0.4Release notes
Sourced from release-it's releases.
... (truncated)
Changelog
Sourced from release-it's changelog.
... (truncated)
Commits
2c87983Release 19.0.42195b79Update dependencies6fc696ffix: set octokit log to {} instead of null (#1237)879a2efReplace lodash.get with custom get() function and add tests (#1231)183050cRelease 19.0.3b792c45Update dependencies9c7d2b3docs(gitlab): update token scope requirements and default secure setting (#1229)96d8889Add default timeout (mainly for tests)1604dc7Minor housekeeping/formattingfccdf67chore: use node's spawn instead of tinyexec dep (#1227)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.