Skip to content

Conversation

@mariacarmina
Copy link
Contributor

@mariacarmina mariacarmina commented Feb 3, 2025

Fixes #402 .

Changes proposed in this PR:

  • fix for unit
  • fix for integration

@mariacarmina mariacarmina self-assigned this Feb 3, 2025
@paulo-ocean
Copy link
Contributor

paulo-ocean commented Feb 14, 2025

btw, had a quick look and don't think this is going on the right track.. we're changing a lot of things unrelated with private keys... hard coding RPCS for instance, is one.. but there are others...
have you ever looked at file src/test/utils/addresses.ts ? we have everything there needed for refactoring the tests around private keys.
tkx

@mariacarmina
Copy link
Contributor Author

btw, had a quick look and don't think this is going on the right track.. we're changing a lot of things unrelated with private keys... hard coding RPCS for instance, is one.. but there are others... have you ever looked at file src/test/utils/addresses.ts ? we have everything there needed for refactoring the tests around private keys. tkx

Ok thank you Paulo, but the purpose was to no expose private keys in the code, now we place them in a separate file... it is a bit confusing, I remeber Alex said to not share private keys anywhere, we can have them as env vars, but it is not clear the scope of the issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove explicit private keys in the code and getSigner(0) from account creation in tests

3 participants