Backup rework #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I might have mistaken an int and a float, which would effectively render useless the whole algo...
rotate_block_split(t_main_cont *cont, t_deque *block_ids, t_block_info *info); block_id_is_in_stack(t_deque *block_ids, int id); has_smaller_than_median(t_deque *stack, t_block_info *info); has_bigger_than_median(t_deque *stack, int median_val, int max_val); assign_block_median(t_deque *stack, t_deque *block_ids, t_block_info *info);
Also removed all malloc calls
My gnl does not seem to return any of the last blank characters at the end of a file...
I ended up having to rewrite a get_next_line from scratch, but I did and it works. It's a simplified version that would not necessarily work with long files, but it can read *up to* buff_size
Next problem : prototypes in deques.h I cannot seem to find a way to declare my function prototypes properly...
I cannot seem to find a way to declare my function pointers that does not mess with norminette
So I figured out what the norminette fuckup was : it does not accept multi-variable function pointer declaration when the return type was not standard (in my case, bool). Switching the return types of the 4 affected functions should do it add_front add_last resize_end resize_front (should add reinit_list for coherence purposes)
Might want to lighten libft by only moving some items, but otherwise done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.