-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[IMP] website/ecommerce: update catalog page #15569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
auva-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This is only the first of two comment batches for this review! But thank you so much already for your tremendous work in this PR 🤯 🙏 !!!)
-
I think it might better (and easier) to structure the beginning of the doc a bit differently to have something that's maybe a bit closer to the options available in the Style tab. I think it would make things easier to understand, and also, for example, the search field/option also controls whether the search field is displayed at the top of the filters so it's not limited tot the "top bar". I would also rename "top bar" into "toolbar" and would maybe have something like this: (h2) Toolbar and filters (let's see if this works!) and then h3s: Categories, Filters, Toolbar. Let's maybe discuss this!
-
As discussed, let's also add a seealso for the Gelato documentation saying something like: Configure the Gelato connector in Odoo to synchronize product catalogs and automate order fulfilment with Gelato.
content/applications/sales/sales/products_prices/products/variants.rst
Outdated
Show resolved
Hide resolved
| To use product variants, the :guilabel:`Variants` setting **must** be activated in the Odoo *Sales* | ||
| application. | ||
|
|
||
| To do that, go to :menuselection:`Sales app --> Configuration --> Settings`, and locate the | ||
| :guilabel:`Product Catalog` section at the top of the page. | ||
|
|
||
| In that section, check the box to enable the :guilabel:`Variants` feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're changing this part anyways, I'd suggest to improve it even further to avoid repetitions 🙈
| To use product variants, go to :menuselection:`Sales --> Configuration --> Settings`, then enable the :guilabel:`Variants` feature in the :guilabel:`Product Catalog` section at the top of the page. |
And I would even remove the screenshot right after this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lman-odoo I think you forgot this comment (sorry!)
content/applications/sales/sales/products_prices/products/variants.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/products/variants.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: sorry it seems I have posted the same comment twice and I can no longer delete my own comments (thank you GitHub ...), I can only edit it. Please ignore this one!
auva-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @lman-odoo, here's the second (and last) part of this first review. Thank you for your patience! As usual, feel free to reach out if anything's unclear or if you'd like to discuss any of my comments/questions!
(PS: Don't forget to avoid you/your when possible (e.g., your website, your products, etc.))
content/applications/websites/ecommerce/products/categories_variants.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/ecommerce/products/categories_variants.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/ecommerce/products/categories_variants.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/ecommerce/products/categories_variants.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/ecommerce/products/categories_variants.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/ecommerce/products/categories_variants.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/ecommerce/products/categories_variants.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/ecommerce/products/categories_variants.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/ecommerce/products/categories_variants.rst
Show resolved
Hide resolved
task-5136241
b497ea4 to
b14b5d9
Compare
auva-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the changes @lman-odoo and good job restructuring the catalog doc page! I have only minor comments mostly, we should be good after this review 🙂
Also, could we please uniformize the way we write ecommerce (in this PR at first and then keep it in mind for the rest of the doc): basically, imo: eCommerce ONLY if we're talking about the app or something in the UI because it's the way they spelled it; for other applications, choose between e-commerce and ecommerce 🙂 --> we can of course discuss this but in any case, i would uniformize!)
| To use product variants, the :guilabel:`Variants` setting **must** be activated in the Odoo *Sales* | ||
| application. | ||
|
|
||
| To do that, go to :menuselection:`Sales app --> Configuration --> Settings`, and locate the | ||
| :guilabel:`Product Catalog` section at the top of the page. | ||
|
|
||
| In that section, check the box to enable the :guilabel:`Variants` feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lman-odoo I think you forgot this comment (sorry!)

task-5136241