Mustang I V2 effects

[krskajo1]

Hello,
this PR adds support for the missing Mustang I V2 effects (Ranger Boost, Greenbox, Orangebox, Blackbox, Big fuzz) and modulations (Wah, Touch Wah, Diatonic Pitch Shifter). The support includes default effect and effect windows.
Main change of this commit is in the ID of individual effects. It seems that they are in fact 16-bit wide, instead of current 8-bit width. This mainly influenced the function lookupEffectById, where I added second parameter uint8_t idmsb with implicit value of 0.

The newly added effects are currently appended to the bottom of the combobox list in the effect window, as their position must correspond with their value in the effects enum.

Additionally I've noticed there is a lot of duplicate code, especially in default effects and effects windows regarding knob labels. I know there might be a good reason for it, such as proper shortcut function, however, I think that by doing this line-efficiently would benefit legibility of the code and make editing it easier.
One solution I come up with and implemented for the new effects utilizes maps to store knob description for given knob like so

mapLbls["Brightness"] = UIText{
  tr("&Brightness"),
  tr("Effect's %1 \"Brightness\" dial").arg(slot.id() + 1),
  tr("Allows you to set \"Brightness\" parameter of this effect"),
  tr("Effect's %1 \"Brightness\" box").arg(slot.id() + 1),
  tr("Allows you to precisely set \"Brightness\" parameter of this effect")};

and sets for an effect

case effects::RANGER_BOOST:
  setTexts(ui.get(),
  mapLbls["Level"],
  mapLbls["Gain"],
  mapLbls["Low"],
  mapLbls["Brightness"],
  mapLbls["Disabled"],
  mapLbls["Disabled"]);
break;

Alternatively, creating a class for each effect (deriving from effect base class), which would define its labels, is also an option.

Please, let me know if you do or don't agree with the map approach and or anything in this PR and what should be changed. I will gladly make the necessary edits.
Best regards
Joe

[krskajo1]

I realized I forgot to implement and run tests. I will implement them and update the PR.

[krskajo1]

Tests and formatting corrected. This PR is now ready for review.

[offa]

We should consider expanding the id type to uint16_t instead. Since it's 0 for other devices, this should be safe.

[krskajo1]

I am totally for changing the type to uint16_t, adding a second parameter was just a less intrusive change.
Should I change it in this PR or create another one?

[offa]

Let's keep working on this PR. No need to create an additional one.

[krskajo1]

Ok. The change is now implemented.

[offa]

Nice, thank you! 👍

[offa]

I gave it a quick test on a v1 device and the v2 effects are listed there too. They should be limited to Mustang I v2 only though.

Also I'd suggest to keep the UI entries sorted and grouped by family. At the moment it's all v1 models, and then the v2.

[offa]

Eventually we should improve the complete text handling here. Ok for now though.

[krskajo1]

I gave it a quick test on a v1 device and the v2 effects are listed there too. They should be limited to Mustang I v2 only though.

Also I'd suggest to keep the UI entries sorted and grouped by family. At the moment it's all v1 models, and then the v2.

Ok, I'll have a chance to look into the displaying the valid effects in a week or two.

By grouping UI elements do you mean e.g., the combo boxes? That the entries should be grouped by their type (stomp box, modulation, delay, reverb)?

[offa]

By grouping UI elements do you mean e.g., the combo boxes? That the entries should be grouped by their type (stomp box, modulation, delay, reverb)?

Exact! The combox list entries grouped by [1], [2] etc. in the UI.