Skip to content

Conversation

@44yu5h
Copy link

@44yu5h 44yu5h commented Apr 6, 2025

Fixes #34

New behaviour:

Screenshot From 2025-04-06 19-09-13

@44yu5h 44yu5h force-pushed the 34-tags-overflow branch from efbf9bd to fac539d Compare April 6, 2025 17:58
@44yu5h
Copy link
Author

44yu5h commented Apr 6, 2025

I realised the empty space on the left was for the size of the package.

I tried using ellipsis, but its behaviour was not consistent since there can be multiple tags

image

@kelson42
Copy link
Member

kelson42 commented Apr 6, 2025

We should have also css elipsis

@rgaudin
Copy link
Member

rgaudin commented Apr 7, 2025

@44yu5h thank you ; can you please check how it looks like at every screen dimension? There are a lot of differences at different sizes and you mx might not work for all use cases (haven't looked at it though).

As @kelson42 suggests (I think), the cut-out is a bit harsh and a visual clue that the text is too long would possibly be better. We do use ellipsis on title if it's too long so I guess we could use it here as well. Simply setting the width and the overflow ellipsis does it.

@siemsie would an ellipsis be OK?

@siemsie
Copy link

siemsie commented Apr 7, 2025

Hi everyone. I imagined something like this. Thank you.

Tags

@44yu5h
Copy link
Author

44yu5h commented Apr 9, 2025

rgaudin ~ can you please check how it looks like at every screen dimension?

Okay, will do!

@siemsie Wow! These edits look so good. Which software do you use?

I'll add the multiline support, ellipsis, tooltip, and increase the maximum number of tags (currently set to 2)

@siemsie
Copy link

siemsie commented Apr 9, 2025

Hi @44yu5h. Thanks – I use Adobe Illustrator, useful tool for quick solutions like this, although not too useful for web.

@44yu5h 44yu5h force-pushed the 34-tags-overflow branch from fac539d to 317dc65 Compare April 10, 2025 01:23
@44yu5h
Copy link
Author

44yu5h commented Apr 10, 2025

Updated behavior:

  • Responsive design for different screen sizes
  • Tooltip
  • Ellipsis
  • 2 lines wrap
  • Multiple tags

image

@44yu5h
Copy link
Author

44yu5h commented Apr 10, 2025

I also noticed the number of columns as 3 for both md and lg. Might it have been a typo?
Seems it should rather be md:grid-cols-2m and behaves better after the change

        sm:grid-cols-1m
        md:grid-cols-3m
        lg:grid-cols-3m
        xl:grid-cols-4m
        2xl:grid-cols-5m

@siemsie
Copy link

siemsie commented Apr 29, 2025

Could you align the tags to the full width of the box, as model above. Thanks

@44yu5h
Copy link
Author

44yu5h commented Apr 29, 2025

@siemsie ~ Could you align the tags to the full width of the box, as model above

I think that space was reserved for the file size of the item. It was already there so I am guessing we had plans of showing that in the future?

Let me know if you'd still want me to remove the space.

@rgaudin
Copy link
Member

rgaudin commented Apr 30, 2025

@44yu5h the size is now gone (see #25) hence the use of that space in @siemsie's mockup

@44yu5h 44yu5h force-pushed the 34-tags-overflow branch from 317dc65 to 5e7bf46 Compare May 12, 2025 23:35
@44yu5h
Copy link
Author

44yu5h commented May 12, 2025

@rgaudin Removed the extra space.

Let me know if everything is alright now. Thanks

@rgaudin
Copy link
Member

rgaudin commented Nov 13, 2025

@44yu5h sorry about the loooooonnng delay in replying. I had the notification aside for review and must have cleared it at some point.

It doesn't work as suggested: there's no space between tags and there's a huge blank space below on every card now.

Screenshot 2025-11-13 at 12 14 05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tags escaping the card boundaries

4 participants