feat(gasprice): Add gas price controller(default mode) #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimmyShi22
force-pushed
the
jimmyshi/gasprice-controller
branch
3 times, most recently
from
724ab64 to
5e271ca
Compare
Author
|
@copilot please describe this PR |
|
@JimmyShi22 I've opened a new pull request, #24, to work on those changes. Once the pull request is ready, I'll request review from you. |
zjg555543
approved these changes
Nov 10, 2025
JimmyShi22
force-pushed
the
jimmyshi/gasprice-controller
branch
from
dd84e5f to
cd92f8f
Compare
JimmyShi22
force-pushed
the
jimmyshi/gasprice-controller
branch
from
bf58221 to
a698831
Compare
zjg555543
approved these changes
Nov 11, 2025
xzav3r
reviewed
Nov 11, 2025
|
|
||
| [[package]] | ||
| name = "ahash" | ||
| version = "0.7.8" |
There was a problem hiding this comment.
There is already an ahash with version 0.8.12. Let's see if we can use that instead
| reth-evm.workspace = true | ||
| reth-rpc-server-types.workspace = true | ||
| reth-tasks = { workspace = true, optional = true } | ||
| reth-tasks.workspace = true |
| /// Validate all X Layer configurations | ||
| pub fn validate(&self) -> Result<(), String> { | ||
| self.intercept.validate() | ||
| self.intercept.validate()?; |
Author
There was a problem hiding this comment.
add this function: self.gas_price.validate()
| } | ||
| } | ||
|
|
||
| impl Default for XLayerGasPriceArgs { |
|
|
||
| /// Default gas price for XLayer (in wei) | ||
| #[arg(long = "xlayer.gasprice.default")] | ||
| pub default: Option<U256>, |
There was a problem hiding this comment.
Using default as a field name is a bit unusual.
| pub use node::*; | ||
|
|
||
| mod node_xlayer; | ||
|
|
There was a problem hiding this comment.
better to group the modules related to xlayer together.
| // } | ||
| _ => { | ||
| tracing::error!("Invalid gas price type: {}", price_type); | ||
| panic!("Invalid gas price type: {}", price_type); |
Collaborator
There was a problem hiding this comment.
the node will crash if use panic.
Author
There was a problem hiding this comment.
done: default to default mode
JimmyShi22
force-pushed
the
jimmyshi/gasprice-controller
branch
2 times, most recently
from
fd67039 to
9105ea8
Compare
JimmyShi22
force-pushed
the
jimmyshi/gasprice-controller
branch
from
9105ea8 to
b7b867a
Compare
Vui-Chee
reviewed
Nov 17, 2025
Comment on lines
+143
to
+145
| pub fn validator_arc(&self) -> &Arc<V> { | ||
| &self.validator | ||
| } |
There was a problem hiding this comment.
Just a thought.
// Implement this trait
impl<V> AsRef<Arc<V>> for TransactionValidationTaskExecutor<V> {
fn as_ref(&self) -> &Arc<V> {
&self.validator
}
}
// Then instead of `self.validator().validator_arc().clone()`, do:
self.validator().as_ref().clone()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements XLayer gas price controller with default mode that control L2 gas prices based on network congestion while maintaining a configured minimum floor.
Architecture
Gas Price Controller (
crates/xlayer/gasprice/)DefaultGasPricer: Returns fixed configured price, no external data dependenciesXLayerScheduler: Periodic updates based on L2 congestion metrics (pending txs, block fullness)GasPriceCache: Thread-safe price storage with raw/adjusted valuesNode Integration (
crates/optimism/node/)node_xlayer.rsxlayer-gas-price-schedulerbackground taskRPC Layer (
crates/optimism/rpc/,crates/rpc/rpc/)XLayerFeestrait onOpEthApifor pricer managementmod_xlayer.rseth_minGasPriceRPC method--rollup.sequencer http://xxxxxis set.Configuration
To enable, add these to op-reth startup params
Future modes (follower, fixed) will calculate
raw_gpfrom L1 prices; default mode uses configured value.