Skip to content

Conversation

@kernelshard
Copy link

  • Fixed dict[str, str] to Dict[str, str] in _utils.py for Python 3.8 support
  • Added Python version matrix (3.8-3.13) to CI testing.

…g CI testing matrix

- Change dict to Dict for Python 3.8 support
- Add Python version matrix (3.8-3.13) to github action test workflow
- Include tox in [tool.hatch.envs.hatch-test].extra-dependencies
- Makes it easy for developers to run multi-version tests locally
- No impact on end users or package size
@ParthSareen ParthSareen self-requested a review December 29, 2025 19:53
@ParthSareen
Copy link
Member

We should be able to test this with hatch.

[[tool.hatch.envs.hatch-test.matrix]]
  python = ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]

something like this in our pyproject.toml instead of using tox. you can use uvx hatch test -acp locally as well. no need to add tox.

@kernelshard
Copy link
Author

kernelshard commented Jan 10, 2026

We should be able to test this with hatch.

[[tool.hatch.envs.hatch-test.matrix]]
  python = ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]

something like this in our pyproject.toml instead of using tox. you can use uvx hatch test -acp locally as well. no need to add tox.

Thanks @ParthSareen for letting me know. But I am confused why this is not working.. Cause if it worked then this code should've raise error at 3.8, as this dict type hint was not supported by then.

def _parse_docstring(doc_string: Union[str, None]) -> dict[str, str]:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants