Skip to content

fix a leak #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olebol wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix a leak #31

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
925c365
change include statement to quotes to specify where the compiler shou…
olebol Dec 10, 2024
8fb6de3
free the header list after last use
olebol Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions include/openai/openai.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
#include "curl/curl.h"
#endif

#include <nlohmann/json.hpp> // nlohmann/json
#include "nlohmann/json.hpp"

namespace openai {

Expand Down Expand Up @@ -192,7 +192,7 @@ inline Response Session::deletePrepare() {

inline Response Session::makeRequest(const std::string& contentType) {
std::lock_guard<std::mutex> lock(mutex_request_);

struct curl_slist* headers = NULL;
if (!contentType.empty()) {
headers = curl_slist_append(headers, std::string{"Content-Type: " + contentType}.c_str());
Expand All @@ -209,7 +209,7 @@ inline Response Session::makeRequest(const std::string& contentType) {
}
curl_easy_setopt(curl_, CURLOPT_HTTPHEADER, headers);
curl_easy_setopt(curl_, CURLOPT_URL, url_.c_str());

std::string response_string;
std::string header_string;
curl_easy_setopt(curl_, CURLOPT_WRITEFUNCTION, writeFunction);
Expand All @@ -218,9 +218,14 @@ inline Response Session::makeRequest(const std::string& contentType) {

res_ = curl_easy_perform(curl_);

if (headers != NULL) {
curl_slist_free_all(headers);
headers = NULL;
}

bool is_error = false;
std::string error_msg{};
if(res_ != CURLE_OK) {
if (res_ != CURLE_OK) {
is_error = true;
error_msg = "OpenAI curl_easy_perform() failed: " + std::string{curl_easy_strerror(res_)};
if (throw_exception_) {
Expand Down