Skip to content

Update user_registration.liquid #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Slashek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update user_registration.liquid #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion instance/forms/user_registration.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ fields:
label: Last Name
validation:
- rule: presence
error: '{{form.fields.last_name.label}} must be provided'
error: '{{form.fields.last_name.label}} must be provided' # maciek: having a form_builder, preferably renamed to form is
great idea. Defining built in validation as array seems to be semantic issue, as it does not make sense to add multiple errors for
"presence" etc - using hash, as it's currently, seems ok to me. IIRC, the main idea was to allow developer to their own
validations - that's something we have recently added, we need to add documentation for it - the idea is quite similar.
email:
label: Email
password:
Expand Down