Skip to content

Try SIGHeartbeatSender #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akarashchuk merged 2 commits into from
Mar 24, 2025
Merged

Try SIGHeartbeatSender #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5942e8
Try SIGHeartbeatSender
akarashchuk Mar 21, 2025
0a15032
PR fix
akarashchuk Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Remote/AMQP/Connector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@
use InvalidArgumentException;
use PhpAmqpLib\Channel\AMQPChannel;
use PhpAmqpLib\Connection\AMQPStreamConnection;
use PhpAmqpLib\Connection\Heartbeat\PCNTLHeartbeatSender;
use PhpAmqpLib\Connection\Heartbeat;

class Connector
{
private ?AMQPChannel $channel = null;
private ?PCNTLHeartbeatSender $heartbeats = null;
private ?Heartbeat\AbstractSignalHeartbeatSender $heartbeats = null;

/**
* @param array<array<mixed>> $hosts
Expand Down Expand Up @@ -63,7 +63,11 @@ public function connect(): AMQPChannel
$connection = AMQPStreamConnection::create_connection($this->hosts, $this->options);
Copy link
Contributor

@zloyuser zloyuser Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А оно не ругнется на неизвестную опцию?

Copy link
Contributor Author

@akarashchuk akarashchuk Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не ругается


if ($connection->getHeartbeat() > 0) {
$this->heartbeats = new PCNTLHeartbeatSender($connection);
$this->heartbeats = match ($this->options['heartbeat_sender'] ?? null) {
'sig' => new Heartbeat\SIGHeartbeatSender($connection),
default => new Heartbeat\PCNTLHeartbeatSender($connection),
};

$this->heartbeats->register();
}

Expand Down