Fix case sensitivity of checkbox #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although checkboxes are parsed with lower and upper case X, the check in isCheckbox is case sensitive. This commit adjusts the test to reveal the bug. Specifically, the test now fails if the first checkbox is checked with a lower case x.
Allow checkboxes to be marked with an 'x' or 'X'.
onmax
approved these changes
Jan 19, 2025
Owner
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @onmax! I noticed a small issue, that may break this GitHub Action in the future.
Checkboxes are parsed to allow both lowercase and uppercase markers,
xandX.issue-form-parser/src/util.ts
Line 48 in 7b55aea
However, the check to identify a checkbox section only allow uppercase
X.issue-form-parser/src/util.ts
Line 39 in 7b55aea
Issues with lowercase
xcheckbox markers fail to be parsed.This pull request adjusts the regular expression in the function
isCheckboxto be case insensitive, much like the parsing.This minor bug is becoming crucial, as GitHub is rolling out a new issues feature that uses lowercase
xin issue templates. This results in this GitHub Action failing to parse issues submitted through an issue template.I prepared three commits: