Skip to content

Conversation

@AgnieszkaZaba
Copy link
Collaborator

No description provided.

@AgnieszkaZaba AgnieszkaZaba requested a review from Sfonxu December 21, 2025 17:13
@AgnieszkaZaba AgnieszkaZaba changed the title hook checking if notebooks executed and without warnings and errors hook checking if notebooks executed with output and without warnings and errors Dec 21, 2025
@slayoo
Copy link
Member

slayoo commented Dec 26, 2025

To make the hooks maintainable, it would be great to store in the repo some example files that demonstrate when the hooks should fail. Chat suggests the following pattern:
image
Could it work?

@Sfonxu
Copy link
Contributor

Sfonxu commented Dec 27, 2025

To make the hooks maintainable, it would be great to store in the repo some example files that demonstrate when the hooks should fail. Chat suggests the following pattern: [...] Could it work?

I think it could, with maybe a more clear naming convention (like tests/passing/(hook_name).py, tests/failing/(hook_name).py )?

Same goes for example notebooks I suppose. And maybe a good idea would be to add a CI job to run the hooks on those files as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants