fix: Create bitfield structs with the correct size #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 1, 2025 00:27
This simplifies definition of bitfields, which would otherwise require specifying ctypes ctypes.
The buggy code used c_uint for all integer fields, resulting in the SpreadSpectrum struct being padded out to 32 bits instead of being 16 bits. The fix uses the field() helper function to specify the correct ctype to use, greatly simplifying the process of defining bitfields.
The bytesize can be calculated from the field descriptions, simplifying the interface and reducing the chance of human error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in #73 that caused
SpreadSpectrum's struct to be created with 32 bits instead of 16 bits. The use ofc_uintfor all integer fields was the direct cause.Changes:
ctypestypes, devs pass a bitfield.INTEGER constant and a bitsize.bytesize=argument is removed;marshalledSizeof bitfields is calculated on creation with a sanity check._field()helper function converts the field description to an appropriate_fields_class variable, deciding the appropriatectypestype to use.