[prometheusreceiver] Prevent GC goroutine accumulation in JobsMap #44922
+43
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under high concurrency, multiple calls to JobsMap.get() could each spawn a gc() goroutine if lastGC was stale, causing unnecessary goroutine accumulation while they wait for the lock. Add an atomic gcRunning flag with compare-and-swap to ensure only one gc goroutine runs at a time. The flag is reset after gc() completes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
fix/gc-goroutine-accumulation
branch
from
907db0f to
885d1fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Under high concurrency, multiple calls to
JobsMap.get()could each spawn agc()goroutine iflastGCwas stale, causing unnecessary goroutine accumulation while they wait for the lock.Add an atomic
gcRunningflag with compare-and-swap to ensure only one gc goroutine runs at a time. The flag is reset aftergc()completes.Link to tracking issue
Fixes
Testing
Documentation