Make Python autoinstrumentation envvar injection consistent with other languages by using appendOrReplace #4565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Braden Chapman braden.chapman@chicagotrading.com
Description: Updated Python environment variable injection for autoinstrumentation to use appendOrReplace() instead of appendIfNotSet(). Other languages use appendOrReplace().
Users at my company deploy their applications into kubernetes using Helm. In the Helm chart, we have the following set:
value: "http://$(NODE_IP):4317"
value: "grpc"
But Python cannot use grpc. When attempting to override the variables in the helm chart by setting them in the Instrumentation object to be used by the autoinstrumentation injection, the helm chart variables take precedent because the Python injection in the operator currently uses appendIfNotSet, whereas other languages use appendOrReplace.