-
Notifications
You must be signed in to change notification settings - Fork 65
Enable SO_REUSEPORT on OSes that support it. #1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enable SO_REUSEPORT on OSes that support it. #1586
Conversation
|
|
#1578 would help such issues from occurring in the future! |
@SAROJJV Clearing the EasyCLA is a mandatory pre-requisite before accepting any contributions. It is a one-time process. |
|
I believe it would make sense to have this PR with the CI build for Windows - else there is no way to validate the changes. |
I have already signed it. Not sure why it is yet getting flaged. |
What will that require? I know it's possible, the Collector has Windows in its CI/CD. I think we should do that; I don't think we should block this PR necessarily. |
No need to block this PR on lack of windows ci. #1578 is something I plan to fix today :) |
|
Not blocking the PR, but good to add a TODO comment that load-balancing is broken for windows, and this needs to be evaluated. |
|
https://github.com/open-telemetry/otel-arrow/actions/runs/20142815332/job/57814915753?pr=1592 We fail on windows precisely due to this! So it confirms windows tests are working 🤣 |
Build fails on windows platforms as set_reuse_port() is not supported on windows platforms. With this change part of the code using set_reuse_port() will only be compiled on Linux & MacOs platforms.