Skip to content

Conversation

@SAROJJV
Copy link

@SAROJJV SAROJJV commented Dec 11, 2025

Build fails on windows platforms as set_reuse_port() is not supported on windows platforms. With this change part of the code using set_reuse_port() will only be compiled on Linux & MacOs platforms.

@SAROJJV SAROJJV requested a review from a team as a code owner December 11, 2025 01:10
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 11, 2025

CLA Not Signed

@github-actions github-actions bot added the rust Pull requests that update Rust code label Dec 11, 2025
@cijothomas
Copy link
Member

#1578 would help such issues from occurring in the future!

@cijothomas
Copy link
Member

CLA Not Signed

@SAROJJV Clearing the EasyCLA is a mandatory pre-requisite before accepting any contributions. It is a one-time process.

@lalitb
Copy link
Member

lalitb commented Dec 11, 2025

I believe it would make sense to have this PR with the CI build for Windows - else there is no way to validate the changes.

@SAROJJV
Copy link
Author

SAROJJV commented Dec 11, 2025

CLA Not Signed

@SAROJJV Clearing the EasyCLA is a mandatory pre-requisite before accepting any contributions. It is a one-time process.

I have already signed it. Not sure why it is yet getting flaged.

@SAROJJV SAROJJV marked this pull request as draft December 11, 2025 03:38
@jmacd
Copy link
Contributor

jmacd commented Dec 11, 2025

I believe it would make sense to have this PR with the CI build for Windows - else there is no way to validate the changes.

What will that require? I know it's possible, the Collector has Windows in its CI/CD. I think we should do that; I don't think we should block this PR necessarily.

@cijothomas
Copy link
Member

I believe it would make sense to have this PR with the CI build for Windows - else there is no way to validate the changes.

What will that require? I know it's possible, the Collector has Windows in its CI/CD. I think we should do that; I don't think we should block this PR necessarily.

No need to block this PR on lack of windows ci. #1578 is something I plan to fix today :)

@lalitb
Copy link
Member

lalitb commented Dec 11, 2025

Not blocking the PR, but good to add a TODO comment that load-balancing is broken for windows, and this needs to be evaluated.

@cijothomas
Copy link
Member

https://github.com/open-telemetry/otel-arrow/actions/runs/20142815332/job/57814915753?pr=1592 We fail on windows precisely due to this! So it confirms windows tests are working 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants