Fix --extra-col-pair example in the docs #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalitsyna
reviewed
Jun 27, 2025
pairtools/cli/dedup.py
Outdated
| 'names (requires the "#columns" header field). The option can be provided ' | ||
| "multiple times if multiple column pairs must match. " | ||
| 'Example: --extra-col-pair "phase1" "phase2". [output format option]', | ||
| 'Example, to dedup phased pairs:' |
Member
There was a problem hiding this comment.
Suggested change:
Example for dedup of phased pairs, remove duplicates matching in columns phase1 and (independently) in column phase2. Note how each --extra-col-pair expects a pair of columns as input:
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Member
Author
|
@agalitsyna just realized we haven't merged this - is it OK now? |
Member
Author
|
I guess I'll just approve it and merge it myself, since it's just innocuous docs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.